Skip to content

Keep the HTML lang attribute in sync with the i18next language #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented May 5, 2025

Small thing that has been bothering me for a bit: Firefox always offers me to translate the page, because it thinks it's in English, even though it's already in French.

@sandhose sandhose requested a review from a team as a code owner May 5, 2025 13:10
@sandhose sandhose requested a review from toger5 May 5, 2025 13:10
@sandhose sandhose added the PR-Improvement Release note category. A PR that improves EC's performance or stability. label May 5, 2025
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandhose,
I have not yet observed that but its because my browser is configured differently.

You tested, that it fixes your situation though right? It does not break anything on my side so I am happy to merge.

@toger5 toger5 merged commit 3808801 into livekit May 5, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Improvement Release note category. A PR that improves EC's performance or stability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants