Skip to content

Add custom audio renderer for iPhone earpiece and only render joined participants #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Add custom audio renderer for iPhone earpiece and only render joined participants #3249

merged 3 commits into from
May 15, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented May 5, 2025 •
edited
Loading

This does two things:

Fixes #2927

@toger5 toger5 requested a review from a team as a code owner May 5, 2025 20:02
@toger5 toger5 requested a review from AndrewFerr May 5, 2025 20:02
@toger5 toger5 force-pushed the toger5/custom-audio-renderer branch from e719617 to 943c50b Compare May 6, 2025 10:21
Half-Shot
Half-Shot previously requested changes May 6, 2025
View reviewed changes
Copy link
Member

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had some questions. Implementation looks sane

@toger5 toger5 added the PR-Feature Release note category. A PR that introduces a new user facing feature. label May 7, 2025
@toger5 toger5 changed the title Add custom audio renderer to only render joined participants Add custom audio renderer for IPhone earpice and to only render joined participants May 7, 2025
@toger5 toger5 changed the title Add custom audio renderer for IPhone earpice and to only render joined participants Add custom audio renderer for IPhone earpice and only render joined participants May 8, 2025
@fkwp fkwp changed the title Add custom audio renderer for IPhone earpice and only render joined participants Add custom audio renderer for iPhone earpice and only render joined participants May 8, 2025
robintown
robintown reviewed May 8, 2025
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully through reviewing the last bits of the MediaDevicesContext changes but here's what I've got:

@toger5 toger5 force-pushed the toger5/custom-audio-renderer branch from 4783f12 to 0f40b44 Compare May 12, 2025 14:12
@toger5
Copy link
Contributor Author

toger5 commented May 12, 2025

@robintown This has changed a bit since we cannot do the fallback to HTML5 audio because HTML5 audio volume control is broken on safari...
I rebased and squashed the changes to cleanup the PR and work on the playwright tests (thats why i wanted/needed to rebase)
I hope this is okay.
I only touched the MatrixAudioRenderer after your review. and it has changed enough so it makes sense to review the whole file again (it got much simpler)

@toger5
Add custom audio renderer to only render joined participants & add io…
5632810 
…s earpice workaround

fix left right to match chromium + safari
(firefox is swapped)

earpice as setting

Simpler code and documentation
The doc explains, what this class actually does and why it is so complicated.

Signed-off-by: Timo K <[email protected]>

use only one audioContext, remove (non working) standby fallback
@toger5 toger5 force-pushed the toger5/custom-audio-renderer branch from b5081c1 to 58d768f Compare May 14, 2025 08:41
@toger5 toger5 force-pushed the toger5/custom-audio-renderer branch from 58d768f to 6b8c620 Compare May 14, 2025 08:59
robintown
robintown reviewed May 14, 2025
View reviewed changes
@toger5 toger5 requested a review from robintown May 14, 2025 15:31
@toger5 toger5 dismissed Half-Shot’s stale review May 14, 2025 15:32

All changes have been applied and the PR changed a lot. Robin took over the final review process.

@fkwp fkwp changed the title Add custom audio renderer for iPhone earpice and only render joined participants Add custom audio renderer for iPhone earpiece and only render joined participants May 14, 2025
@toger5 toger5 merged commit b5fe55a into livekit May 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot left review comments

@robintown robintown robintown approved these changes

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees
No one assigned
Labels
PR-Feature Release note category. A PR that introduces a new user facing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only subscribe to audio from MatrixRTC members
3 participants
@toger5 @Half-Shot @robintown