Update RTCSession configuration to non deprecated names. #3267
Conversation
toger5
added
the
PR-Task
toger5
force-pushed
the
toger5/update-to-js-sdk-non-deprecated-names
branch
from
62fa425 to
1c975ab
Compare
toger5
force-pushed
the
toger5/update-to-js-sdk-non-deprecated-names
branch
from
2aecd64 to
7f90a0b
Compare
src/e2ee/matrixKeyProvider.ts
Outdated
| @@ -44,7 +44,7 @@ export class MatrixKeyProvider extends BaseKeyProvider { | |||
| encryptionKeyIndex: number, | |||
| participantId: string, | |||
| ): void => { | |||
| createKeyMaterialFromBuffer(encryptionKey).then( | |||
| createKeyMaterialFromBuffer(encryptionKey.buffer as ArrayBuffer).then( | |||
There was a problem hiding this comment.
This warning is a bit annoying, a .buffer is not necessarly an ArrayBuffer?
I wonder why we are having this warning only now... TBH I don't understand
At the end it is calling subtle crypto importKey that accepts An ArrayBuffer, a TypedArray, a DataView...
I don't know what is the best way to fix that.
We change our API to use ArrayBuffer? We call directly import key? or we request a change to createKeyMaterialFromBuffer
There was a problem hiding this comment.
So could be that:
crypto.subtle.importKey('raw', encryptionKey, 'HKDF', false, [
'deriveBits',
'deriveKey',
]).then(
If not what do we do if encryptionKey.buffer is not an ArrayBuffer? Maybe we could throw an error ?
There was a problem hiding this comment.
This seems like a good idea to me. I just added a commit patching this.
toger5
force-pushed
the
toger5/update-to-js-sdk-non-deprecated-names
branch
from
e54e966 to
832972b
Compare
|
I just tried a to-device call with this and .dev and they seem to understand their keys (so we dont break the key format in a unexpected way. Which is the thing i was most concerned about) |
As introduced in: matrix-org/matrix-js-sdk#4714
Is blocked until we bump the js-sdk to a version supporting the new names.This pr now also updates the js-sdk version