Skip to content

Fix Playwright tests #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 30, 2025
Merged

Fix Playwright tests #3294

merged 12 commits into from
May 30, 2025

Conversation

fkwp
Copy link
Contributor

@fkwp fkwp commented May 27, 2025 •
edited
Loading

This PR aims at fixing Playwright tests by:

  • Resolve port conflicts in docker-compose dev-backend-docker-compose.yml in conjunction with using the element web docker container
    • Change JWT port to 6080 to not conflict with the playwright tests.
  • Adapt playwright element web fixture to work with the optional UX flow "Confirm your identity by entering your account password below."
  • Fix test.skip() to properly ignore Firefox

@fkwp fkwp requested a review from a team as a code owner May 27, 2025 14:34
@fkwp fkwp requested a review from AndrewFerr May 27, 2025 14:34
@fkwp fkwp added the PR-Bug-Fix Release note category. A PR that fixes a bug. label May 27, 2025
@fkwp fkwp changed the title Resolve port conflicts in docker-compose dev-backend-docker-compose.yml Fix Playwright tests May 27, 2025
robintown
robintown reviewed May 28, 2025
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the tests aren't actually fixed…

@fkwp fkwp marked this pull request as draft May 29, 2025 10:57
@fkwp
refactor: splitout registerUser into its own function. Make the'Confi…
d572977 
…rm your identity by entering your account password below.' flow optional
@fkwp fkwp requested a review from robintown May 30, 2025 13:10
@fkwp fkwp marked this pull request as ready for review May 30, 2025 13:11
@fkwp fkwp mentioned this pull request May 30, 2025
Merged
robintown
robintown approved these changes May 30, 2025
View reviewed changes
playwright/fixtures/widget-user.ts
Comment on lines +110 to +112
} catch {
// continueButton not visible, continue as normal
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is necessary while Element Web is in a transition period toward using a new registration flow, if I'm interpreting this correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@robintown robintown added X-Blocked Cannot be merged due to external dependencies and removed X-Blocked Cannot be merged due to external dependencies labels May 30, 2025
@robintown robintown enabled auto-merge May 30, 2025 14:41
@robintown robintown merged commit 5f8a8d4 into livekit May 30, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees
No one assigned
Labels
PR-Bug-Fix Release note category. A PR that fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkwp @robintown