Skip to content

Only use ios platform logic when in controlled media device condition #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Only use ios platform logic when in controlled media device condition #3295

merged 1 commit into from
May 30, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented May 27, 2025

No description provided.

@toger5 toger5 requested a review from a team as a code owner May 27, 2025 14:40
@toger5 toger5 requested a review from BillCarsonFr May 27, 2025 14:40
@robintown robintown added the PR-Bug-Fix Release note category. A PR that fixes a bug. label May 28, 2025
@toger5
Copy link
Contributor Author

toger5 commented May 30, 2025 •
edited
Loading

I am not exactly sure anymore we want/need this. It does make sense but on the other hand it is also useful to have the native button in the SPA on iphone. At least as long as we still have the SPA.
We do since the button relies on controlled devices. So even though it would be nice to have this in spa it just is not possible -> we should not show the button.

@toger5 toger5 merged commit 8718605 into livekit May 30, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees
No one assigned
Labels
PR-Bug-Fix Release note category. A PR that fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toger5 @robintown