Expose keep alive event configurarion in ec config and update defaults. #3303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
reviewed
Jun 4, 2025
toger5
force-pushed
the
toger5/delayed-event-config
branch
from
c600605 to
0567a8a
Compare
fkwp
reviewed
Jun 10, 2025
fkwp
reviewed
Jun 10, 2025
fkwp
reviewed
Jun 10, 2025
fkwp
reviewed
Jun 10, 2025
src/config/ConfigOptions.ts
Outdated
Comment on lines
121
to
122
| * How long (in milliseconds) after the last keep-alive the server should expire the | ||
| * MatrixRTC membership event. |
There was a problem hiding this comment.
Suggested change
| * How long (in milliseconds) after the last keep-alive the server should expire the | |
| * MatrixRTC membership event. | |
| * The duration (in milliseconds) after the most recent keep-alive (delayed leave event restart) | |
| * that the server waits before emitting the expire MatrixRTC membership event. |
fkwp
reviewed
Jun 10, 2025
fkwp
reviewed
Jun 10, 2025
fkwp
reviewed
Jun 10, 2025
Co-authored-by: fkwp <[email protected]>
Co-authored-by: fkwp <[email protected]>
Co-authored-by: fkwp <[email protected]>
fkwp
reviewed
Jun 10, 2025
| key_rotation_on_leave_delay: 15000, | ||
| membership_keep_alive_period: 5000, | ||
| membership_server_side_expiry_timeout: 15000, | ||
| wait_for_key_rotation_ms: 5000, |
There was a problem hiding this comment.
I don't know. In general the larger the better the experience. So probably 5000 is fine. Even though the example proposes a smaller value. (but then the sample is just the example and we wont always update it if we tune this part so them diverging is not an issue I think)
This was referenced Jun 11, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.