Skip to content

add onAudioPlaybackStarted callback for controls #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

add onAudioPlaybackStarted callback for controls #3309

merged 2 commits into from
Jun 10, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jun 3, 2025

No description provided.

@toger5 toger5 requested a review from a team as a code owner June 3, 2025 11:39
@toger5 toger5 requested a review from AndrewFerr June 3, 2025 11:39
@toger5 toger5 added the PR-Improvement Release note category. A PR that improves EC's performance or stability. label Jun 3, 2025
jmartinesp
jmartinesp reviewed Jun 3, 2025
View reviewed changes
jmartinesp
jmartinesp reviewed Jun 3, 2025
View reviewed changes
@jmartinesp
Copy link
Member

I think I finally fixed the bug we discussed on EXA thanks to this callback, thanks!

@jmartinesp jmartinesp mentioned this pull request Jun 3, 2025
Merged
9 tasks
robintown
robintown reviewed Jun 4, 2025
View reviewed changes
@toger5
Copy link
Contributor Author

toger5 commented Jun 4, 2025

@robintown really good points. I will convert it into a draft for now since a proper PR needs your changes. It was done as a "maybe this helps unblock android" experiment.

@toger5 toger5 marked this pull request as draft June 4, 2025 21:26
@toger5 toger5 marked this pull request as ready for review June 5, 2025 11:47
@toger5 toger5 force-pushed the toger5/controls-callback-on-devices-ready branch from f4944ee to f33b27e Compare June 5, 2025 11:48
@toger5 toger5 changed the title add onAudioTrackReady callback for controls add onAudioPlaybackStarted callback for controls Jun 5, 2025
@toger5 toger5 force-pushed the toger5/controls-callback-on-devices-ready branch from f33b27e to ce1cf4a Compare June 5, 2025 16:12
robintown
robintown approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still could be nice to have a little more context as to what issue EXA was facing without this change, but the API looks right for what it does

@toger5 toger5 merged commit a596eb7 into livekit Jun 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

@robintown robintown robintown approved these changes

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees
No one assigned
Labels
PR-Improvement Release note category. A PR that improves EC's performance or stability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toger5 @jmartinesp @robintown