-
Notifications
You must be signed in to change notification settings - Fork 119
Earpiece switcher and overlay #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
reviewed
Jun 23, 2025
896177d
to
c1201c4
Compare
@fkwp This is now ready for testing! Expect to see two headers on mobile until we get to the EX tasks listed in https://github.com/element-hq/voip-internal/issues/360 |
This will be used by Element X to show an earpiece toggle button in the header.
The header needs to be passed forward as a string to some components and as a bool (hideHeader) to others. Also use a enum instead of string options.
- make video render below the header on Android.
9ad3c41
to
d5ba119
Compare
c15a639
to
ef9bcd1
Compare
ef9bcd1
to
eb294b1
Compare
d40b102
to
a8e67b7
Compare
df07f5b
to
b01a129
Compare
(also show quick switcher if headphones are connected)
toger5
approved these changes
Jun 25, 2025
We now need the room name in order to implement the mobile (widget-based) designs with the app bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple things still need doing here:
Split the header out into another PR, maybe?This requires us to also swap the icon colors for the header bar icons
Potential candidates for a follow up PR
Closes #3271