-
Notifications
You must be signed in to change notification settings - Fork 119
Skip unnecassary media devices permissions requests (video feed flicker when opening settings) #3353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robintown
merged 5 commits into
livekit
from
toger5/device-permissions-request-possible-fix
Jun 25, 2025
Merged
Skip unnecassary media devices permissions requests (video feed flicker when opening settings) #3353
robintown
merged 5 commits into
livekit
from
toger5/device-permissions-request-possible-fix
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b6e1fc
to
aa88618
Compare
39eaa4c
to
5fbca0c
Compare
dc0dbe0
to
54702e8
Compare
robintown
reviewed
Jun 25, 2025
d755131
to
4e22cc5
Compare
eb2ef9a
to
7e32cde
Compare
robintown
approved these changes
Jun 25, 2025
7e32cde
to
9154002
Compare
9154002
to
d08a180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
p1
Must fix/implement before this is usable as a product
PR-Improvement
Release note category. A PR that improves EC's performance or stability.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the discussion:
#3334 (comment)
Which I think we should not forget to fix.
I merged the initial PR so this PR is also a tracker to not forget about this issue.
This does not work in the lobby but does work in call. The lobby is planned to become part of the call anyways so we do not have the camera restart when switching from lobby to call.A way was found to also fix this in the lobby.