Skip to content

Skip unnecassary media devices permissions requests (video feed flicker when opening settings) #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jun 20, 2025

This is based on the discussion:
#3334 (comment)

Which I think we should not forget to fix.
I merged the initial PR so this PR is also a tracker to not forget about this issue.

This does not work in the lobby but does work in call. The lobby is planned to become part of the call anyways so we do not have the camera restart when switching from lobby to call.
A way was found to also fix this in the lobby.

@toger5 toger5 force-pushed the toger5/device-permissions-request-possible-fix branch from 7b6e1fc to aa88618 Compare June 23, 2025 08:53
@toger5 toger5 changed the base branch from robin/mvvm-media-devices to livekit June 23, 2025 09:20
@toger5 toger5 marked this pull request as ready for review June 23, 2025 09:21
@toger5 toger5 requested a review from a team as a code owner June 23, 2025 09:21
@toger5 toger5 requested a review from BillCarsonFr June 23, 2025 09:21
@toger5 toger5 force-pushed the toger5/device-permissions-request-possible-fix branch from 39eaa4c to 5fbca0c Compare June 23, 2025 11:46
@toger5 toger5 force-pushed the toger5/device-permissions-request-possible-fix branch from dc0dbe0 to 54702e8 Compare June 23, 2025 12:00
@toger5 toger5 changed the title Refactor media devices to live outside React as Observables - follow up for permission request discussion Skip unnecassary media devices permissions requests (fix camera flicker when opening settings) Jun 24, 2025
@toger5 toger5 changed the title Skip unnecassary media devices permissions requests (fix camera flicker when opening settings) Skip unnecassary media devices permissions requests (video feed flicker when opening settings) Jun 24, 2025
@robintown robintown force-pushed the toger5/device-permissions-request-possible-fix branch from d755131 to 4e22cc5 Compare June 25, 2025 18:27
@robintown robintown force-pushed the toger5/device-permissions-request-possible-fix branch 2 times, most recently from eb2ef9a to 7e32cde Compare June 25, 2025 19:46
@robintown robintown force-pushed the toger5/device-permissions-request-possible-fix branch from 7e32cde to 9154002 Compare June 25, 2025 19:48
@robintown robintown enabled auto-merge June 25, 2025 19:48
@robintown robintown force-pushed the toger5/device-permissions-request-possible-fix branch from 9154002 to d08a180 Compare June 25, 2025 19:50
@robintown robintown merged commit c012aec into livekit Jun 25, 2025
20 of 23 checks passed
@toger5 toger5 added p1 Must fix/implement before this is usable as a product PR-Improvement Release note category. A PR that improves EC's performance or stability. labels Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Must fix/implement before this is usable as a product PR-Improvement Release note category. A PR that improves EC's performance or stability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants