bugfix: #3344 Reconnecting to the same SFU on membership change #3361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
reviewed
Jun 24, 2025
We've now fixed it at the source by prohibiting state changes in useActiveLivekitFocus itself.
robintown
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3344
This a an ugly workaround, the root cause is that we have a problem with react hooks and a re-render is causing effects with non properly working dependencies to be ran again?This has changed to actually address the root cause: the
activeFocusstate returned by theuseActiveLivekitFocushook was updating with new objects that had the same values. (so we switched to the same focus)Now
useActiveLivekitFocusbehaves as expected, only returning new objects when there is a change.