Remove code which loads legacy libolm #27650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we use the Rust crypto stack (matrix-org/matrix-react-sdk#12630), the legacy olm library is unneeded. Remove all the dedicated cruft for loading it. (All this crap is why matrix-sdk-crypto-wasm has to base64 its wasm artifact, cf matrix-org/matrix-rust-sdk#1167.)
t3chguy
approved these changes
Jun 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
ohh this breaks the playwright tests because they still use legacy crypto. |
Member
Author
|
Playwright tests fixed by matrix-org/matrix-react-sdk#12708. matrix-org/matrix-js-sdk#4301 was also needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use the Rust crypto stack (matrix-org/matrix-react-sdk#12630), the legacy olm library is unneeded. Remove all the dedicated cruft for loading it.
(It is to avoid all this application-level crap that matrix-sdk-crypto-wasm has to base64 its wasm artifact, cf matrix-org/matrix-rust-sdk#1167.)