Remove ingress.host from wellKnownDelegation #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyff of changes in rendered templates of CI manifestsNo changes in rendered templates |
benbz
force-pushed
the
bbz/well-known-delegation-ingress
branch
from
441cd22 to
581181d
Compare
benbz
force-pushed
the
bbz/well-known-delegation-ingress
branch
from
581181d to
0e3c5eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Well-Known Delegation Ingress should always use
serverNameas its host. It doesn't need a distinct host.There are deliberate differences between
ingress_global.jsonandingress.json/ingress_without_host.json-service.typeis required for the global ingress config but not on the per-ingress config (so that they default through). The annotations can be nullable iningress.json/ingress_without_host.jsonto unset global ingress annotations.