Remove the trigger added in #18260 and then reverted #18373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
approved these changes
Apr 29, 2025
| -- <https://www.gnu.org/licenses/agpl-3.0.html>. | ||
|
|
||
| -- Removes the trigger that was added in #18260 and then reverted | ||
| DROP TRIGGER IF EXISTS event_stats_increment_counts_trigger ON events; |
There was a problem hiding this comment.
I double-checked whether DROP TRIGGER IF EXISTS is valid syntax (it is!) given CREATE TRIGGER IF NOT EXISTS does not work in Postgres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18260
This is useful for anyone who tried Synapse v1.129.0rc1 out
Fixes #18349
To test:
\dS eventswith postgres)