wayland: Add make_modal protocol method #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@leolost2605 can you resolve conflicts here? Would love to get this feature in :) |
leolost2605
force-pushed
the
leolost/make-modal
branch
from
a9f8226 to
748fc28
Compare
Member
Author
|
@danirabbit do we want to dim everything or leave shell elements like wingpanel and dock undimmed? |
Member
|
@leolost2605 probably everything |
leolost2605
force-pushed
the
leolost/make-modal
branch
from
85d9156 to
380a6b2
Compare
leolost2605
force-pushed
the
leolost/make-modal
branch
from
380a6b2 to
209ac16
Compare
leolost2605
force-pushed
the
leolost/make-modal
branch
3 times, most recently
from
0965cc0 to
eeaead8
Compare
Member
Author
|
This will keep the same behavior as main on older mutter which currently is only opensuse leap 15 afaik. Leap 16 has been released so this should be fine IMO. |
leolost2605
force-pushed
the
leolost/make-modal
branch
from
eeaead8 to
4b932a3
Compare
leolost2605
force-pushed
the
leolost/make-modal
branch
from
4b932a3 to
06daa2c
Compare
lenemter
reviewed
Oct 30, 2025
leolost2605
force-pushed
the
leolost/make-modal
branch
from
06daa2c to
608ed95
Compare
leolost2605
force-pushed
the
leolost/make-modal
branch
from
608ed95 to
78d8df5
Compare
leolost2605
force-pushed
the
leolost/make-modal
branch
2 times, most recently
from
3cde3d1 to
ace3167
Compare
Member
|
@lenemter can we have a re-review here? I'd love to get this in for OS 8.1 :) |
lenemter
approved these changes
Nov 20, 2025
Member
|
@leolost2605 can you address this final review comment? :) |
leolost2605
force-pushed
the
leolost/make-modal
branch
from
ace3167 to
f56a2b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450
Takes a bunch of stuff from #1879 and makes it a wayland protocol method.
This will open up a bunch of useful possibilities like making end session, polkit, etc. dialogs modal with a dimmed background or like using GTK for the window switcher in an external process (that's also why dimming is optional).
For the pantheon wayland part see elementary/pantheon-wayland#7
For testing elementary/pantheon-agent-polkit#92 can be used. For that the pantheon wayland PR is also required
There is no change in behavior on X