Fix RoundedCornersEffect #2655
Open
Fix RoundedCornersEffect #2655
+100
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
reviewed
Nov 21, 2025
|
|
||
| private void update_clip_radius () requires (actor != null) { | ||
| var resource_scale = actor.get_resource_scale (); | ||
| set_uniform_value ("clip_radius", Utils.scale_to_int (clip_radius, monitor_scale / resource_scale)); |
Member
There was a problem hiding this comment.
Why do we divide by the resource scale here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's a charm
Rename .vert shaders to .frag because well, these are fragment shaders, not vertex shaders.
Fixes the strange offsets in shader code by correctly calculating offsets using clutter_actor_box_enlarge_for_effects which is mutter private api. This works with and without fractional scaling which was the flaw of my previous attempts