Fix device support #533
Open
Fix device support #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTMLAnchorElement is such a basic element and have existed for a long time. react-native is not a web application and as such i don't think filesaver will not work at all. The question i have is how you manage to surpass this condition... Lines 70 to 71 in 813a31f maybe in react native saveAs should only be a noop function? |
|
This is fix for issue from bpampuch/pdfmake#1664 more information can be provided by @dancomanlive and @PatrickCavalcanti |
Uzlopak
approved these changes
Apr 14, 2019
|
Any chance to this get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed support for mobile device.
Application in React throw error
Can't find variable: HTMLAnchorElementon mobile device.Original pdfmake issue with example: bpampuch/pdfmake#1664