Skip to content
This repository was archived by the owner on May 15, 2019. It is now read-only.
This repository was archived by the owner on May 15, 2019. It is now read-only.

PHP Warnings on FEE_Field_[FieldName] implementations of wrap() #310

@apotek

Description

@apotek

Expected behaviour and actual behaviour

Plugin works as expected, but generates a WARNING on every wordpress execution, targeting various fields. Some examples:

PHP Warning: Declaration of FEE_Field_Single_Title::wrap($title) should be compatible with FEE_Field_Term_Field::wrap($content, $term_id, $taxonomy) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

PHP Warning: Declaration of FEE_Field_Option::wrap($content, $key, $ui) should be compatible with FEE_Field_Base::wrap($content, $data) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

PHP Warning: Declaration of FEE_Field_Term_Field::wrap($content, $term_id, $taxonomy) should be compatible with FEE_Field_Base::wrap($content, $data) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

The signature of the base clase is different than the signature in the implemented class. This can lead to bugs, and given the name of the parameters, I would imagine there is a bug here, though I haven't experienced a behavior.

Steps to reproduce the problem

Load any wordpress page with front-end-editor plugin installed.

Specifications

  • Browser Name and Version: Any browser. Applies to any request to server whether using curl, or chrome, or firefox. Currently using curl.
  • WordPress Version: 4.7.2
  • Plugin Version: 2.3.1
  • Theme name/URL:

Error messages

PHP Warning: Declaration of FEE_Field_Single_Title::wrap($title) should be compatible with FEE_Field_Term_Field::wrap($content, $term_id, $taxonomy) in /foo/bar/wordpress/wp-content/plugins/front-end-editor/php/fields/other.php on line 0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions