fix: exclude never-seen servers from availability percentage calculation #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix still counted servers in the availability percentage if they were marked as available by the API, even if they had never been seen. This change ensures that only servers that have actually been seen available (not showing "Never") are counted in the percentage calculation. Instead of filtering from the availableTypes array, we now filter from supportedTypes and only count those where getLastSeenAvailable returns a non-null value. Fixes #214 Co-authored-by: Simon Elsbrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix still counted servers in the availability percentage if they were marked as available by the API, even if they had never been seen. This change ensures that only servers that have actually been seen available (not showing "Never") are counted in the percentage calculation.
Instead of filtering from the availableTypes array, we now filter from supportedTypes and only count those where getLastSeenAvailable returns a non-null value.
Fixes #214