fix: resolve CI failures in dependency PRs #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update package-lock.json to sync with package.json (fixes npm ci failures) - Fix unused variable linting errors preventing builds - Add localStorage mocking for settings tests - Prefix unused variables with underscore to satisfy eslint This resolves the root cause of failures in PRs #227, #223, #222, and #208 which were all failing due to package-lock.json being out of sync. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
elsbrock
force-pushed
the
fix/ci-failures-dependency-prs
branch
from
35886e1 to
12b2638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause Analysis
All failing PRs were encountering the same issue:
npm ciwas failing because package-lock.json was out of sync with package.json. This caused build failures with missing @esbuild packages.Changes Made
Test Plan
npm test)npm run lint)npm run build)npm ci)This should allow the dependency update PRs to pass their CI checks and be merged successfully.
🤖 Generated with Claude Code