Skip to content

133: added warning to README.org about possible conflicts with ob-ipython #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cheremin
Copy link
Contributor

No description provided.

@@ -398,6 +398,11 @@ example you can put the following in your configuration:
(setq ob-async-no-async-languages-alist '("jupyter-python" "jupyter-julia"))
#+END_SRC

*** Issues with =ob-ipython=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you run M-x org-fill-paragraph (bound to M-q) on the two paragraphs so that they are formatted like the rest of the document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, np, here is it

README.org Outdated
@@ -398,6 +398,11 @@ example you can put the following in your configuration:
(setq ob-async-no-async-languages-alist '("jupyter-python" "jupyter-julia"))
#+END_SRC

*** Issues with =ob-ipython=
If you already have =ob-ipython= installed, you /may/ experience issues with it conflicting with =emacs-jupyter= (e.g. [[https://github.com/dzop/emacs-jupyter/issues/133#issuecomment-502444999][this issue]). This is still not clearly investigated, but worth to keep in mind.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the ending bracket of the link.

Suggested change
If you already have =ob-ipython= installed, you /may/ experience issues with it conflicting with =emacs-jupyter= (e.g. [[https://github.com/dzop/emacs-jupyter/issues/133#issuecomment-502444999][this issue]). This is still not clearly investigated, but worth to keep in mind.
If you already have =ob-ipython= installed, you /may/ experience issues with it conflicting with =emacs-jupyter= (e.g. [[https://github.com/dzop/emacs-jupyter/issues/133#issuecomment-502444999][this issue]]). This is still not clearly investigated, but worth to keep in mind.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we remove the part This is still not clearly investigated, but worth to keep in mind. and just give a brief explanation of the linked issue.

I took a look at ob-ipython and it has to do with its Jupyter kernel support. Both emacs-jupyter and ob-ipython try to take ownership of jupyter-LANG source block names. So if both ob-ipython and emacs-jupyter are installed, ob-ipython will partially override what emacs-jupyter does to handle jupyter-LANG source blocks. The only way to suppress this is to remove the org-mode-hook function added by ob-ipython before an org-mode file is opened. Due to this, ob-ipython and emacs-jupyter are incompatible.

So you can actually replace this whole paragraph saying that ob-ipython must be uninstalled in order for emacs-jupyter to work properly since both packages define jupyter-LANG source blocks and, if you want, mention a little about why from the explanation above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I have rephrase this block according to your investigation.

BTW: Thank you for investigation -- as for me, it is much simpler to just know tools are inherently incompatible, then guess that else could be the cause of incompatibility

@nnicandro nnicandro merged commit 7918293 into emacs-jupyter:master Jul 24, 2019
@nnicandro
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants