Centralize SymbolInformation rendering #2310
Conversation
In various different parts of `lsp', where SymbolInformation has to be rendered (lsp-ivy, lsp-treemacs, lsp-imenu), only the :name is shown as a string. This is insufficient, as other information is then ignore displayed (currently only :deprecated?). Add a function, `lsp-render-symbol-information', which behaves similar to `lsp-render-symbol'. Use it in `lsp--imenu-create-non-hierarchical' index.
There was a problem hiding this comment.
Not part of this review ATM the issue is that you cannot navigate to element if it has children which is a very big limitation when we are rendering DocumentSymbol. The proposal is to build a list(not tree) with the following structure
Container1 / Container2 / Node
Willing to address this limitation?
|
I'm sorry, but I don't understand your request. SymbolInformation has no :children field. It's :container-name? field is also probably hacky to rely on, as the LSP Protocol spec says "[...] It [ |
|
I am talking about DocumentSymbol |
|
That is coincidentally exactly what I am working on right now. |
|
The CI failure isn't my fault - "spinner" isn't installable. |
In various different parts of
lsp, where SymbolInformation has to berendered (lsp-ivy, lsp-treemacs, lsp-imenu), only the :name is shown as
a string. This is insufficient, as other information is then ignore
displayed (currently only :deprecated?).
Add a function,
lsp-render-symbol-information, which behaves similarto
lsp-render-symbol. Use it inlsp--imenu-create-non-hierarchicalindex.