Add lsp-flush-delayed-changes-before-next-message option #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some LSP clients spam the server with message, such as "textDocument/codeAction" requests on every keystroke, so if we require synchronizing the delayed changes before the next LSP message, it looses its meaning: In most cases the next cursor movement comes right after a change, so `lsp--send-no-wait` forces the change notification out before it sends the codeAction request. Let the users of the slow LSP servers that depend on this change notification throttling customize this behavior to choose their own tradeoff.
jcs090218
approved these changes
Jul 28, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some LSP clients spam the server with message, such as "textDocument/codeAction" requests on every keystroke, so if we require synchronizing the delayed changes before the next LSP message, it looses its meaning: In most cases the next cursor movement comes right after a change, so
lsp--send-no-waitforces the change notification out before it sends the codeAction request.Let the users of the slow LSP servers that depend on this change notification throttling customize this behavior to choose their own tradeoff.