adds to cerberus-hybrid.html#286
Merged
TedGoas merged 4 commits intoemailmonday:mainfrom Mar 19, 2022
Merged
Conversation
It's helpful for this PR, but most folks won't need this code comment in the template.
Collaborator
|
@matthieuSolente Hey this is great! Your solution is simpler than what I did in #285. I made a few small updates to your PR, none of which change the actual fix you're proposing. I tested in Email on Acid and everything checks out. Would you mind reviewing the commits I added? If everything looks good, let's merge this! |
TedGoas
added
the
bug
Collaborator
|
@matthieuSolente Hiya Mattieu, do you think you'd be able to give this a brief look sometime soon? |
Collaborator
|
@matthieuSolente I gave this second look and think it's good to go. Unless you have any objections, I'd like to merge this and get a new version out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an additional row to line 568 on the alternating block to separate the padding from the direction statement dir="rtl". This removes the unwanted vertical line of 1px on all Outlook. We add padding on the first level cell, and the direction on the internal cell