Add N6 support #612
Add N6 support #612
Conversation
|
@Dirbaio can you please have a sharp look at my renaming effort for the ENUM values? |
|
looks good from a quick look. anything in particular you want me to check / any particular question? |
|
If there are some unwritten naming conventions, you would probably spot them. The easiest is to look at the diff of e2a5bda. Fixing the duplication error I need to read up in the docs as in my understanding right now there is a bit of a difference in the fields flaged as duplicate. |
|
It generates and building pac works. |
|
As there is no flash I have not defined any flash if someone wonders at review. |
|
there is no flash holy shit |
|
bender run |
stm32-data-gen/src/rcc.rs
Outdated
| @@ -243,7 +275,9 @@ impl ParsedRccs { | |||
| stop_mode: StopMode::default(), | |||
| }; | |||
|
|
|||
| if en_rst.insert(peri.to_string(), val).is_some() { | |||
| println!("{}: {} -> {:?}", rcc_version, peri, val); | |||
There was a problem hiding this comment.
these prints are spamming quite a lot at gen time, could you remove them?
|
Removed printing. They were nice to find some errors in the yaml. |
|
Ok, there is something wrong I guess ... It should not add all those signals and interrupts to other chips. |
Yeah, something new for the stm32 and I think it will be a lot of pain :D And there might be some variants with flash later. |
|
@Dirbaio The diff looks better to me :) |
|
🚀 |
Adding support for N6