Support deleting volume with snapshots #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a soft-delete mechanism for volumes so they can be "deleted" even when they have snapshots. The expected behavior of deleting a volume with snapshots is not well defined in the CSI spec, as stated in issue container-storage-interface/spec#346 but until this is clarified we will assume that PR #347 will be accepted and we must behave like this. This is also how the csi-sanity test suite seems to expect us to behave. Close: embercsi#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a soft-delete mechanism for volumes so they can be
"deleted" even when they have snapshots.
The expected behavior of deleting a volume with snapshots is not well
defined in the CSI spec, as stated in issue
container-storage-interface/spec#346 but until
this is clarified we will assume that PR #347 will be accepted and we
must behave like this.
This is also how the csi-sanity test suite seems to expect us to behave.
Close: #70