Skip to content

handle glimmer validator patch failure #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

handle glimmer validator patch failure #2663

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03a72fc
handle glimmer validator patch failure
patricklx Jun 24, 2025
ae3df32
fix lint
patricklx Jun 24, 2025
4ad903c
fix
patricklx Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 31 additions & 27 deletions ember_debug/object-inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,33 +39,37 @@ if (GlimmerValidator) {
track = GlimmerValidator.track;

// patch tagFor to add debug info, older versions already have _propertyKey
const tagFor = GlimmerValidator.tagFor;
GlimmerValidator.tagFor = function (...args) {
const tag = tagFor.call(this, ...args);
const [obj, key] = args;
if (
(!tag._propertyKey || !tag._object) &&
typeof obj === 'object' &&
typeof key === 'string'
) {
tag._propertyKey = key;
tag._object = obj;
}
return tag;
};
const trackedData = GlimmerValidator.trackedData;
GlimmerValidator.trackedData = function (...args) {
const r = trackedData.call(this, ...args);
if (r.getter && args.length === 2) {
const [key] = args;
const getter = r.getter;
r.getter = function (self) {
GlimmerValidator.tagFor(self, key);
return getter.call(this, self);
};
}
return r;
};
try {
const tagFor = GlimmerValidator.tagFor;
GlimmerValidator.tagFor = function (...args) {
const tag = tagFor.call(this, ...args);
const [obj, key] = args;
if (
(!tag._propertyKey || !tag._object) &&
typeof obj === 'object' &&
typeof key === 'string'
) {
tag._propertyKey = key;
tag._object = obj;
}
return tag;
};
const trackedData = GlimmerValidator.trackedData;
GlimmerValidator.trackedData = function (...args) {
const r = trackedData.call(this, ...args);
if (r.getter && args.length === 2) {
const [key] = args;
const getter = r.getter;
r.getter = function (self) {
GlimmerValidator.tagFor(self, key);
return getter.call(this, self);
};
}
return r;
};
} catch {
// cannot patch
}
} else if (GlimmerReference) {
tagValue = GlimmerReference.value;
tagValidate = GlimmerReference.validate;
Expand Down