Skip to content

Commit 14bd2e2

Browse files
Remove hard dependency on Browser from Asyncify (#12181)
Instead, check if Browser exists or not, and add direct dependencies on Browser from the specific async wget methods that actually need full Browser support. Split out from #12165 Saves 13KB from a minified build.
1 parent 836c194 commit 14bd2e2

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/library_async.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ mergeInto(LibraryManager.library, {
2020
},
2121

2222
#if ASYNCIFY
23-
$Asyncify__deps: ['$Browser', '$runAndAbortIfError'],
23+
$Asyncify__deps: ['$runAndAbortIfError'],
2424
$Asyncify: {
2525
State: {
2626
Normal: 0,
@@ -213,7 +213,7 @@ mergeInto(LibraryManager.library, {
213213
#endif
214214
Asyncify.state = Asyncify.State.Rewinding;
215215
runAndAbortIfError(function() { Module['_asyncify_start_rewind'](Asyncify.currData) });
216-
if (Browser.mainLoop.func) {
216+
if (typeof Browser !== 'undefined' && Browser.mainLoop.func) {
217217
Browser.mainLoop.resume();
218218
}
219219
var start = Asyncify.getDataRewindFunc(Asyncify.currData);
@@ -251,7 +251,7 @@ mergeInto(LibraryManager.library, {
251251
err('ASYNCIFY: start unwind ' + Asyncify.currData);
252252
#endif
253253
runAndAbortIfError(function() { Module['_asyncify_start_unwind'](Asyncify.currData) });
254-
if (Browser.mainLoop.func) {
254+
if (typeof Browser !== 'undefined' && Browser.mainLoop.func) {
255255
Browser.mainLoop.pause();
256256
}
257257
}
@@ -287,13 +287,14 @@ mergeInto(LibraryManager.library, {
287287
},
288288
},
289289

290+
emscripten_sleep__deps: ['$Browser'],
290291
emscripten_sleep: function(ms) {
291292
Asyncify.handleSleep(function(wakeUp) {
292293
Browser.safeSetTimeout(wakeUp, ms);
293294
});
294295
},
295296

296-
emscripten_wget__deps: ['$PATH_FS', '$FS'],
297+
emscripten_wget__deps: ['$Browser', '$PATH_FS', '$FS'],
297298
emscripten_wget: function(url, file) {
298299
Asyncify.handleSleep(function(wakeUp) {
299300
var _url = UTF8ToString(url);
@@ -316,6 +317,7 @@ mergeInto(LibraryManager.library, {
316317
});
317318
},
318319

320+
emscripten_wget_data__deps: ['$Browser'],
319321
emscripten_wget_data: function(url, pbuffer, pnum, perror) {
320322
Asyncify.handleSleep(function(wakeUp) {
321323
Browser.asyncLoad(UTF8ToString(url), function(byteArray) {

0 commit comments

Comments
 (0)