-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove hard dependency on Browser from Asyncify #12181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard dependency on Browser from Asyncify #12181
Conversation
I'm not sure if something similar should be done for FS. It doesn't actually declare a dependency, so I guess if Browser doesn't exist for any other reason then there will just be some hanging references, so you better not call Lines 1900 to 1930 in 5fb249c
Edit: actually I think that might be happening in the I'm not sure what the best way to organise these dependencies is, probably adding Edit: Okay, I've added a |
Arguably the dependency should be on FS, but this is simpler and means if you use other FS functions Browser won't necessarily have to be included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think this is a good first step.
The planned work to split out the main loop handling could be even better. We could in that case emit different code when emscripten_set_main_loop
(the function that shows the main loop is actually used) is called by the user or not, maybe.
Split out from #12165
Remove the hard dependency on Browser from Asyncify. Could save 13KB from a minified build.