Skip to content

Commit 22c03b5

Browse files
authored
Disable browser.test_pthread_create with minimal runtime, which is flakey (#12383)
See #12368 - the flakiness in the test appears to be 100% due to the minimal runtime part, so something specific is racy there. After spending a little time I saw nothing obvious, but maybe I'm not familiar enough with minimal runtime to know where to look, that is, where the differences between the runtimes would be regarding pthreads. For now this disables that test on minimal runtime, and also makes the test stricter - it's 100% deterministic so there's no need to retry once after a failure (which actually made the flakiness here harder to notice). Note that this does not remove all minimal runtime + pthreads tests, as there is still test_minimal_runtime_hello_pthread (which is simpler, and shows no flakiness).
1 parent b22065b commit 22c03b5

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

tests/test_browser.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -3659,11 +3659,16 @@ def test_pthread_gcc_spinlock(self):
36593659
def test_pthread_create(self):
36603660
def test(args):
36613661
print(args)
3662-
self.btest(path_from_root('tests', 'pthread', 'test_pthread_create.cpp'), expected='0', args=['-s', 'INITIAL_MEMORY=64MB', '-s', 'USE_PTHREADS=1', '-s', 'PTHREAD_POOL_SIZE=8'] + args)
3662+
self.btest(path_from_root('tests', 'pthread', 'test_pthread_create.cpp'),
3663+
expected='0',
3664+
args=['-s', 'INITIAL_MEMORY=64MB', '-s', 'USE_PTHREADS=1', '-s', 'PTHREAD_POOL_SIZE=8'] + args,
3665+
extra_tries=0) # this should be 100% deterministic
36633666
print() # new line
36643667
test([])
36653668
test(['-O3'])
3666-
test(['-s', 'MINIMAL_RUNTIME=1'])
3669+
# TODO: re-enable minimal runtime once the flakiness is figure out,
3670+
# https://github.com/emscripten-core/emscripten/issues/12368
3671+
# test(['-s', 'MINIMAL_RUNTIME=1'])
36673672

36683673
# Test that preallocating worker threads work.
36693674
@requires_threads

0 commit comments

Comments
 (0)