browser.test_pthread_create more flakey in CI in recent days. #12368
Comments
sbc100
changed the title
kripken
added a commit
that referenced
this issue
Oct 2, 2020
…akey (#12383) See #12368 - the flakiness in the test appears to be 100% due to the minimal runtime part, so something specific is racy there. After spending a little time I saw nothing obvious, but maybe I'm not familiar enough with minimal runtime to know where to look, that is, where the differences between the runtimes would be regarding pthreads. For now this disables that test on minimal runtime, and also makes the test stricter - it's 100% deterministic so there's no need to retry once after a failure (which actually made the flakiness here harder to notice). Note that this does not remove all minimal runtime + pthreads tests, as there is still test_minimal_runtime_hello_pthread (which is simpler, and shows no flakiness).
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've seen this test flake quite a few times recently. e.g:
https://app.circleci.com/pipelines/github/emscripten-core/emscripten/8321/workflows/ac5e8100-f66c-4ef2-bc54-b37ad3db84de/jobs/361395
The text was updated successfully, but these errors were encountered: