Skip to content

Commit 9558567

Browse files
authored
Fix benchmark suite (#15566)
This regressed in #12869 - while adding wasm64 support we reordered how the args are added. The extra emcc args must be at the end so that they apply on top of the other ones, in particular, some tests must disable minimal runtime.
1 parent b266f10 commit 9558567

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

tests/test_benchmark.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,17 +204,19 @@ def build(self, parent, filename, args, shared_args, emcc_args, native_args, nat
204204
EMCC, filename,
205205
OPTIMIZATIONS,
206206
'-s', 'INITIAL_MEMORY=256MB',
207-
'-s', 'FILESYSTEM=0',
208207
'-s', 'ENVIRONMENT=node,shell',
209208
'-s', 'BENCHMARK=%d' % (1 if IGNORE_COMPILATION and not has_output_parser else 0),
210209
'-o', final
211-
] + shared_args + emcc_args + LLVM_FEATURE_FLAGS + self.extra_args
210+
] + shared_args + LLVM_FEATURE_FLAGS
212211
if common.EMTEST_FORCE64:
213212
cmd += ['--profiling']
214213
else:
215214
cmd += ['--closure=1', '-sMINIMAL_RUNTIME']
216-
if 'FORCE_FILESYSTEM' in cmd:
217-
cmd = [arg if arg != 'FILESYSTEM=0' else 'FILESYSTEM=1' for arg in cmd]
215+
# add additional emcc args at the end, which may override other things
216+
# above, such as minimal runtime
217+
cmd += emcc_args + self.extra_args
218+
if 'FORCE_FILESYSTEM' not in cmd:
219+
cmd += ['-s', 'FILESYSTEM=0']
218220
if PROFILING:
219221
cmd += ['--profiling-funcs']
220222
self.cmd = cmd

0 commit comments

Comments
 (0)