Fix benchmark suite #15566
Merged
Fix benchmark suite #15566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Nov 18, 2021
| # above, such as minimal runtime | ||
| cmd += emcc_args + self.extra_args | ||
| if 'FORCE_FILESYSTEM' not in cmd: | ||
| cmd += ['-s', 'FILESYSTEM=0'] |
There was a problem hiding this comment.
Why explicitly disable the filesystem here? (i.e. why not let emcc decide it filesystem is needed or not?)
There was a problem hiding this comment.
I think the reasoning for this moved code is that most benchmarks don't use files, and power users will be disabling the filesystem entirely which can save a few more bytes in some cases.
sbc100
approved these changes
Nov 19, 2021
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
This regressed in emscripten-core#12869 - while adding wasm64 support we reordered how the args are added. The extra emcc args must be at the end so that they apply on top of the other ones, in particular, some tests must disable minimal runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in #12869 - while adding wasm64 support we reordered how the
args are added. The extra emcc args must be at the end so that they apply on
top of the other ones, in particular, some tests must disable minimal runtime.