Skip to content

Do we need the list of authors in AUTHORS? #14354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kripken opened this issue Jun 3, 2021 · 8 comments · Fixed by #14893
Closed

Do we need the list of authors in AUTHORS? #14354

kripken opened this issue Jun 3, 2021 · 8 comments · Fixed by #14893

Comments

@kripken
Copy link
Member

kripken commented Jun 3, 2021

I believe I added that file back in 2010 or so because I saw it done in other projects, as a simple way to have a list of contributors, in case we ever wanted to change license. However, in recent years I don't think I see other projects maintaining such lists any more - the git history basically contains the same info anyhow.

Perhaps we can remove the list? This would make things slightly simpler for new contributors, to not need to add themselves to the file in their first PR.

@kripken
Copy link
Member Author

kripken commented Jun 3, 2021

For comparison, chromium does maintain an AUTHORS file which is mentioned in the contributing docs as a requirement.

@kleisauke
Copy link
Collaborator

kleisauke commented Jun 3, 2021

I noticed with several open source projects that the AUTHORS file is usually used in combination with a contributor license agreement (CLA). Perhaps it's not necessary when there's no CLA present at all (with the usual "I am not a lawyer" proviso)? https://opensource.google/docs/releasing/authors/ might also be relevant here.

Also for comparison, the libjxl project requires you to sign Google's CLA and to add yourself to the AUTHORS file (which is checked by tools/check_author.py in CI). It also has an CONTRIBUTORS file for individuals who made significant contributions on this project.

@kripken
Copy link
Member Author

kripken commented Jun 10, 2021

Interesting, thanks @kleisauke

I'll try to find time to look into this more offline. This does seem more complicated than I had thought.

@goldwaving
Copy link
Contributor

The email address I provided in the AUTHORS list is receiving a rapidly increasing number of junk messages (mostly scams). The address was created exclusively for the emscripten AUTHORS list and was not provided anywhere else. AUTHORS lists seem to be an easy target for email address harvesters.

@kripken
Copy link
Member Author

kripken commented Aug 16, 2021

Sorry to hear that @goldwaving ...

We can remove your email there if you want (if so please open a PR doing that).

@kripken
Copy link
Member Author

kripken commented Aug 17, 2021

Good news, I've confirmed that AUTHORS is in fact not really necessary. I opened #14893 to mark it is optional. New contributors can ignore it from now on.

kripken added a commit that referenced this issue Aug 17, 2021
I have received guidance that AUTHORS is not strictly needed. Like most
projects, we can just rely on git history if we ever need the list of
contributors.

However, since we have the file, we should keep it around for historical
purposes. Just mark it as optional.

We should also disable the bot that auto-suggests people add themselves.

fixes #14354
thyrrestrup pushed a commit to thyrrestrup/emscripten that referenced this issue Aug 18, 2021
…4893)

I have received guidance that AUTHORS is not strictly needed. Like most
projects, we can just rely on git history if we ever need the list of
contributors.

However, since we have the file, we should keep it around for historical
purposes. Just mark it as optional.

We should also disable the bot that auto-suggests people add themselves.

fixes emscripten-core#14354
@mmarczell-graphisoft
Copy link
Contributor

https://emscripten.org/docs/contributing/AUTHORS.html still says, in direct contradiction with the note in the file itself (emphasis mine):

Authors must add themselves to the AUTHORS file before contributing. This act licenses their changes under the project’s open source licenses (MIT/LLVM). Note that the developer retains copyright.

@sbc100
Copy link
Collaborator

sbc100 commented Dec 22, 2021

Looks like that was overlooked when we changed the policy in #14893. The file in question that would need an update is site/source/docs/contributing/AUTHORS.rst. Feel free to send a patch if you have time.

kripken pushed a commit that referenced this issue Jan 4, 2022
Adds notes discussed in #14354 and #15592 , specifically
about AUTHORS being optional, and linking to the code style docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants