Generalize test in prep for binaryen#2510 #10011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test unnecessarily checked for the presence of an explicit type in a function definition in a .wast. The upcoming PR emscripten-core#2510 removes this type from wast output, so this test needed to be updated first to keep the rollers happy.
sbc100
approved these changes
Dec 11, 2019
tlively
changed the title
tlively
changed the title
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…-core#10011) This test unnecessarily checked for the presence of an explicit type in a function definition in a .wast. The upcoming PR emscripten-core#2510 removes this type from wast output, so this test needed to be updated first to keep the rollers happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test unnecessarily checked for the presence of an explicit type
in a function definition in a .wast. The upcoming WebAssembly/binaryen#2510
removes this type from wast output, so this test needed to be updated first to
keep the rollers happy.