Refactor and simplify asyncify logic for calling back in #12081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
callStackIdToFunc
, the map of ids to functions. Instead itmakes us always use the map of ids to function names. That removes one
of the two mechanisms and makes the code simpler, which will help in a
followup PR that adds support for direct table calls, which we need for
#12059.
I think we kept both mechanisms because I was worried about performance,
but I think I was wrong. After debugging for #12059 I think I have a better
understanding of things and it seems fine to use names - it's just a single
JS map lookup for asyncify operation, which is small compared to the
actual asyncify overhead.
Move some code to
maybeStopUnwind
, with no changes. That codewill be useful in the followup as well.
Also clean up some debugging code to make it more useful.
@Akaricchi please take a look, thanks!