Optimize -s MIN_WEBGL_VERSION=2 and WebGL context creation #12623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Oct 29, 2020
src/library_html5_webgl.js
Outdated
| 'preserveDrawingBuffer': !!HEAP32[a + ({{{ C_STRUCTS.EmscriptenWebGLContextAttributes.preserveDrawingBuffer }}}>>2)], | ||
| 'powerPreference': __emscripten_webgl_power_preferences[powerPreference], | ||
| 'failIfMajorPerformanceCaveat': !!HEAP32[a + ({{{ C_STRUCTS.EmscriptenWebGLContextAttributes.failIfMajorPerformanceCaveat }}}>>2)] | ||
| }; | ||
| contextAttributes.majorVersion = HEAP32[a + ({{{ C_STRUCTS.EmscriptenWebGLContextAttributes.majorVersion }}}>>2)]; |
There was a problem hiding this comment.
I think you can still add the ones without quotations to the object literal, without quotations? Or does stuff like this confuse closure?
var x = {
'y': 1,
z: 2
};There was a problem hiding this comment.
Indeed that works.. Oddly that causes Closure to completely oddly change a minification decision afterwards, and it stops optimizing if-else into a ternary ?:, losing whatever bytes it gained from there.
juj
force-pushed
the
optimize_webgl2_only
branch
from
54e7d77 to
6fb8f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro-optimize WebGL context creation code, and when targeting WebGL 2 only, drop WebGL 1 specific code.
Shrinks tests/minimal_webgl JS code size by 389 bytes, from 4882 bytes to 4493 bytes. (-7.97%).