Cleanup makeGetSlabs in src/parseTools.js. NFC. #13290
Conversation
sbc100
commented
Jan 20, 2021
sbc100
commented
- Make fall throughs more obvious.
- Remove break after return.
- Remove unused final return (it was unreachable).
src/parseTools.js
Outdated
| } | ||
| return []; | ||
| throw 'what, exactly, can we do for unknown types in TA2?! ' + [new Error().stack, ptr, type, allowMultiple, unsigned]; |
There was a problem hiding this comment.
We should probably fix this error message too. I think TA2 refers to USE_TYPED_ARRAYS which was removed in 2015.
Do you know why this function used to return more than one thing? Were there multiple memory views that we used to try to keep in sync somehow?
There was a problem hiding this comment.
Yes, as you said, this is super-old...
I believe we used to not have a single linear memory, but separate ones per type. This was one of the approaches experimented with in the very early days.
Today I think this can return a single item, and the error here can just be "internal error".
sbc100
force-pushed
the
cleanup_makeGetSlabs
branch
from
146d248 to
e9fa04e
Compare
src/parseTools.js
Outdated
| } | ||
| return []; | ||
| throw 'what, exactly, can we do for unknown types in TA2?! ' + [new Error().stack, ptr, type, allowMultiple, unsigned]; |
There was a problem hiding this comment.
Yes, as you said, this is super-old...
I believe we used to not have a single linear memory, but separate ones per type. This was one of the approaches experimented with in the very early days.
Today I think this can return a single item, and the error here can just be "internal error".
- Make fall throughs more obvious. - Remove break after return. - Remove unused final return (it was unreachable).
sbc100
force-pushed
the
cleanup_makeGetSlabs
branch
from
e9fa04e to
9ae6e46
Compare
Followup on #13290. We only deal with a single heap these days so we can remove some of the complexity here.
Followup on #13290. We only deal with a single heap these days so we can remove some of the complexity here.
Followup on #13290. We only deal with a single heap these days so we can remove some of the complexity here.
