-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Avoid scalarization in _mm_madd_epi16 #13454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I just noticed that the Note that on the latest version of Chrome (v88) this just works with the |
Thanks for the PR! SIMD will be standardized very soon and at that point I will be removing the |
91510a0
to
98bbe2b
Compare
OK, I skipped the |
98bbe2b
to
cf907f6
Compare
... rebased on top of the master branch to (hopefully) resolve the test failures. |
Great, thanks for the update. Would you mind updating the docs on instruction performance to reflect this change as well? |
cf907f6
to
952d765
Compare
I updated the docs, and was able to reproduce the Here's the salient part of the log: Details
|
Ah, thanks for looking into that. The issue is that the builtin functions expect specifically typed arguments whereas the intrinsics all operate in terms of a generic |
952d765
to
6e51622
Compare
The
i32x4.dot_i16x8_s
instruction was merged into the SIMD proposal with WebAssembly/simd#127.This instruction is already supported in Chrome stable. On the latest versions of Node, it can be tested with the
--wasm-simd-post-mvp
V8 flag. See for example: