Remove post_build hooks in test runner. NFC - #14444
Merged
Merged
Conversation
sbc100
enabled auto-merge (squash)
June 14, 2021 18:41
kripken
reviewed
Jun 14, 2021
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
lgtm with that suggestion (not clicking "approve" since automerge)
We can just use the `--post-js` and `--extern-post-js` options these days.
sbc100
force-pushed
the
remove_post_build
branch
from
June 14, 2021 23:51
33d4155 to
08ee5dc
Compare
sbc100
disabled auto-merge
June 14, 2021 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can just use the
--post-jsand--extern-post-jsoptionsthese days.