Avoid compile error on test_aligned_alloc #15024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent commit taught clang that the first parameter to aligned_alloc should be a power of two alignment, and since then clang emits a warning (which we upgrade to an error) when that argument is a constant that is not a power of two. Since the test actually wants to test the function behavior in that case, ignore the error.
dschuff
approved these changes
Sep 11, 2021
CDLlo
pushed a commit
to CDLlo/emscripten
that referenced
this pull request
Oct 4, 2021
A recent commit taught clang that the first parameter to aligned_alloc should be a power of two alignment, and since then clang emits a warning (which we upgrade to an error) when that argument is a constant that is not a power of two. Since the test actually wants to test the function behavior in that case, ignore the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit taught clang that the first parameter to aligned_alloc should be
a power of two alignment, and since then clang emits a warning (which we upgrade
to an error) when that argument is a constant that is not a power of two. Since
the test actually wants to test the function behavior in that case, ignore the
error.