Skip to content

Add a failfast command-line option to runner.py #15111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Add a failfast command-line option to runner.py #15111

merged 1 commit into from
Sep 24, 2021

Conversation

aardappel
Copy link
Collaborator

This is functionality already exposed by TextTestRunner.

This is functionality already exposed by `TextTestRunner`.
@aardappel aardappel requested a review from kripken September 23, 2021 22:07
@aardappel aardappel merged commit 63e4ef3 into main Sep 24, 2021
@aardappel aardappel deleted the failfast branch September 24, 2021 17:00
@sbc100
Copy link
Collaborator

sbc100 commented Sep 24, 2021

Thanks for doing this. Does this work with the parallel test runner?

@sbc100
Copy link
Collaborator

sbc100 commented Sep 24, 2021

It seems not. For example, if i force all dylink tests to fail then run wasm2 test suite with --failfast it still tries to runs everything it seems:

./tests/runner wasm2 --failfast --skip-slow
...

----------------------------------------------------------------------
Ran 754 tests in 53.236s

FAILED (failures=72, skipped=26)

@sbc100
Copy link
Collaborator

sbc100 commented Sep 24, 2021

72 failures.. but ran all 754 tests

@aardappel
Copy link
Collaborator Author

Yes, it be nice if it worked with parallel tests too.. I guess I usually have all the test debugging stuff on anyway which turns that off.

@sbc100
Copy link
Collaborator

sbc100 commented Sep 24, 2021

Would be cool to combine with some kind of "restart-suite-from-last-failure" feature too.. so one could iterate through the test suite fixing one thing at a time.

@aardappel
Copy link
Collaborator Author

that would have saved me a lot of time, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants