Skip to content

Cleanup val.h docs #15212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Cleanup val.h docs #15212

merged 3 commits into from
Oct 7, 2021

Conversation

RReverser
Copy link
Collaborator

Got fed up with all those TODOs a bit 😅 So finally went through the methods and updated / wrote / cleaned up descriptions.

@RReverser RReverser requested review from kripken and sbc100 October 4, 2021 17:36
@RReverser
Copy link
Collaborator Author

FWIW I'll have a follow-up with a small val extension + doc update but I'll rather wait for this PR to be merged first to reduce conflicts.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % last comment

@RReverser RReverser enabled auto-merge (squash) October 7, 2021 20:51
@RReverser RReverser merged commit c6c304a into main Oct 7, 2021
@RReverser RReverser deleted the val-h-docs branch October 7, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants