[Memory64] new 64-bit related command-line flags #15218
Conversation
emscripten.py
Outdated
| @@ -127,6 +127,9 @@ def update_settings_glue(metadata, DEBUG): | |||
|
|
|||
| # start with the MVP features, and add any detected features. | |||
| settings.BINARYEN_FEATURES = ['--mvp-features'] + metadata['features'] | |||
| # ensure '--enable-memory64' is set exactly once: | |||
| if settings.MEMORY64 and '--enable-memory64' not in settings.BINARYEN_FEATURES: | |||
| settings.BINARYEN_FEATURES += ['--enable-memory64'] | |||
There was a problem hiding this comment.
There is still an open discussion on this in the big PR I think, #12869 (comment)
There was a problem hiding this comment.
Removed this change.
| @@ -127,6 +127,8 @@ def main(): | |||
| help='build relocatable objects for suitable for dynamic linking') | |||
| parser.add_argument('--force', action='store_true', | |||
| help='force rebuild of target (by removing it first)') | |||
| parser.add_argument('--wasm64', action='store_true', | |||
| help='use wasm64 architecture') | |||
There was a problem hiding this comment.
FYI tools/gen_struct_info.py will need the exact same command line argument I think
|
Hmm these |
|
Which pthread tests are you referring to? The ones in |
|
If you have a particular test that are sure the flaky (not one that is part of the cascade of [no server output] failure that often seems to occur with browser tests), can you search the issues for the name of the test and open a new issue with the link the flake? I'm trying to do for any tests that I'm sure are flaking. |
|
Sorry, do not recall which one it was, will do next time. But yes, sure it was a flake, given this PR. |
No description provided.