[Memory64] wasi JS changes for 64-bit #15224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Oct 4, 2021
sbc100
reviewed
Oct 5, 2021
sbc100
reviewed
Oct 5, 2021
src/library_wasi.js
Outdated
| @@ -181,7 +183,7 @@ var WasiLibrary = { | |||
| #if SYSCALLS_REQUIRE_FILESYSTEM == 0 && (!MINIMAL_RUNTIME || EXIT_RUNTIME) | |||
| $flush_NO_FILESYSTEM: function() { | |||
| // flush anything remaining in the buffers during shutdown | |||
| if (typeof _fflush !== 'undefined') _fflush(0); | |||
| if (typeof _fflush !== 'undefined') _fflush({{{ sizeT(0) }}}); | |||
There was a problem hiding this comment.
Do you have pointerT already? (fflush takes a pointer) (if not its probably not worth adding it for this one place).
There was a problem hiding this comment.
renamed it, since this seemed the only use of the function.
sbc100
approved these changes
Oct 7, 2021
| var ptr = {{{ makeGetValue('iov', 'i*8', 'i32') }}}; | ||
| var len = {{{ makeGetValue('iov', 'i*8 + 4', 'i32') }}}; | ||
| var ptr = {{{ makeGetValue('iov', `i*${Runtime.POINTER_SIZE}*2`, `${POINTER_TYPE}`) }}}; | ||
| var len = {{{ makeGetValue('iov', `i*${Runtime.POINTER_SIZE}*2 + ${Runtime.POINTER_SIZE}`, `${POINTER_TYPE}`) }}}; |
There was a problem hiding this comment.
We should probably be using C_STRUCTS stuff here.. I can look into that as a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.