[Memory64] preamble JS changes for 64-bit #15225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Oct 4, 2021
| (function(name) { | ||
| var original = exports[name]; | ||
| var replacement = original; | ||
| if (name === 'stackAlloc' || name === 'malloc') { |
There was a problem hiding this comment.
This method won't work if we minify the names of exports, which we do in -O3 etc. For now, please add a comment // TODO: support minified export names, and in a later PR we should disable that minification for MEMORY64 for now (that would be in minify_wasm_imports_and_exports in tools/building.py)
There was a problem hiding this comment.
Addressed here: #15305
This was referenced Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.