Remove unnecessary use of Runtime.getNativeFieldSize. NFC
#15234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
Oct 5, 2021
| @@ -480,7 +480,7 @@ function checkSafeHeap() { | |||
| } | |||
|
|
|||
| function getHeapOffset(offset, type) { | |||
| if (Runtime.getNativeFieldSize(type) > 4 && type == 'i64') { | |||
There was a problem hiding this comment.
This check was redundant since the field size of i64 is always greater than 4.
sbc100
commented
Oct 5, 2021
src/runtime.js
Outdated
| getNativeFieldSize: function(type) { | ||
| return Math.max(getNativeTypeSize(type), Runtime.QUANTUM_SIZE); | ||
| }, | ||
|
|
There was a problem hiding this comment.
Again I'm not sure how to remove this function safely since its conceivable that somebody out there is using this in a library.js file.
There was a problem hiding this comment.
I think it's fine to remove this but please mention in the changelog, with an explanation of the replacement (call Runtime.getNativeTypeSize instead and max up to 4).
There was a problem hiding this comment.
I decided to play it safe and not actually remove the function.. and instead try to come up with a consistent way to deprecate/remove stuff. See: #15242
sbc100
force-pushed
the
remove_getNativeFieldSize
branch
from
ac4186e to
c9f8565
Compare
sbc100
changed the title
Runtime.getNativeFieldSize. NFC
sbc100
force-pushed
the
remove_getNativeFieldSize
branch
from
c9f8565 to
6fcfe54
Compare
kripken
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.