[Memory64] strftime changes for 64-bit #15303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Oct 14, 2021
|
@sbc100 comments: #12869 (comment) |
|
As I said in the other PR, our policy is not to try for fix existing compiler warnings in musl. Instead we disable them. emscripten/tools/system_libs.py Lines 682 to 688 in d0bccda |
|
review again when #13006 lands |
|
#13006 has now landed? I'm not sure how it effects this proposed change? Maybe its not needed anymore? |
|
IIUC this should no longer be needed... it was to fix a compiler warning/error, but since we are already building libc for wasm64 we know that there are none.. so I think this can be closed. |
|
Please re-open if my understanding is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.