Skip to content

Add multithreaded variant to ICU port #15592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Add multithreaded variant to ICU port #15592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd6c80d
Add multithreaded variant to ICU port
mmarczell-graphisoft Nov 22, 2021
9174024
Implement code review suggestions
mmarczell-graphisoft Nov 23, 2021
08d14b6
Add newline as requested
mmarczell-graphisoft Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions tests/other/test_pthread_icu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#include <thread>
#include <iostream>
#include <thread>
#include <unicode/unistr.h>

// Test that code using both pthread and icu compiles.
int main () {
std::thread([] {
std::string str;
icu::UnicodeString ustr("Hello world!");
ustr.toUTF8String(str);
std::cout << str << std::endl;
}).detach();
}
int main() {
std::thread([] {
std::string str;
icu::UnicodeString ustr("Hello world!");
ustr.toUTF8String(str);
std::cout << str << std::endl;
}).join();
}
1 change: 1 addition & 0 deletions tests/other/test_pthread_icu.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello world!
8 changes: 6 additions & 2 deletions tests/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11126,8 +11126,12 @@ def test_pthread_out_err(self):
self.do_other_test('test_pthread_out_err.c')

@node_pthreads
def test_icu_mt(self):
self.do_smart_test(test_file('other/test_pthread_icu.cpp'), emcc_args=['-pthread', '-sUSE_ICU', '-sPTHREAD_POOL_SIZE_STRICT=4', '-sEXIT_RUNTIME'])
def test_pthread_icu(self):
self.set_setting('USE_PTHREADS')
self.set_setting('USE_ICU')
self.set_setting('PROXY_TO_PTHREAD')
self.set_setting('EXIT_RUNTIME')
self.do_other_test('test_pthread_icu.cpp')

# unistd tests

Expand Down