Added pkgconfig file for GLFW #17100
Conversation
system/lib/pkgconfig/glfw3.pc
Outdated
| Name: GLFW | ||
| Description: A multi-platform library for OpenGL, window and input | ||
| Version: 3.2.1 | ||
| Libs: -s USE_GLFW=3 |
There was a problem hiding this comment.
We tend to recommend no space after -s these days.
|
Could we add some kind of test for this? Would it be best to test directly by running If you want to test directly you could run |
|
I missed enabling the test in test-windows, but that should be it from my side afterwards if the tests will pass. |
Head branch was pushed to by a user without write access
|
|
||
| @wraps(func) | ||
| def decorated(self, *args, **kwargs): | ||
| if not utils.which('pkg-config'): |
There was a problem hiding this comment.
Can you add a EMTEST_SKIP_PKG_CONFIG setting (see the existing EMTEST_SKIP_V8) so that we can disable these tests in certain environments.
There was a problem hiding this comment.
Sure, done in 211f806
.circleci/config.yml
Outdated
| @@ -439,7 +439,7 @@ jobs: | |||
| - pip-install: | |||
| python: "$EMSDK_PYTHON" | |||
| - run-tests: | |||
| test_targets: "other.test_es5_transpile other.test_emcc_cflags other.test_stdin other.test_bad_triple core2.test_sse1 core2.test_ccall other.test_closure_externs other.test_binaryen_debug other.test_js_optimizer_parse_error other.test_output_to_nowhere other.test_emcc_dev_null other.test_cmake* other.test_system_include_paths other.test_emar_response_file core2.test_utf16 other.test_special_chars_in_arguments other.test_toolchain_profiler other.test_realpath_nodefs other.test_response_file_encoding other.test_libc_progname other.test_realpath other.test_embed_file_dup other.test_dot_a_all_contents_invalid" | |||
| test_targets: "other.test_es5_transpile other.test_emcc_cflags other.test_stdin other.test_bad_triple core2.test_sse1 core2.test_ccall other.test_closure_externs other.test_binaryen_debug other.test_js_optimizer_parse_error other.test_output_to_nowhere other.test_emcc_dev_null other.test_cmake* other.test_system_include_paths other.test_emar_response_file core2.test_utf16 other.test_special_chars_in_arguments other.test_toolchain_profiler other.test_realpath_nodefs other.test_response_file_encoding other.test_libc_progname other.test_realpath other.test_embed_file_dup other.test_dot_a_all_contents_invalid other.test_pkg_config*" | |||
There was a problem hiding this comment.
I just landed a change to reformat this list into multiple lines, so I'm afraid you will need to rebase this.
There was a problem hiding this comment.
Sure, no worries.
|
Looks like a rebase/merge is needed |
|
Failure in test-browser-chrome appears to be unrelated. I don't have permissions to rerun it. I guess I could push something to trigger it, but that would invalidate the review, so no matter what it needs maintainer attention. |
|
Would it be worth mentioning stuff like this in the changelog perhaps? |
Addresses #2387 for GLFW.
Configuration misses
prefixand other usual variables to stay in line with existing files. Moreover for the same reason it does not defineCflagswith include directory path. If it is desirable I can look into ways of defining these variables for all of the libraries that are part of the core distribution (but this requires way more research into Emscripten on my part to get it done in a solid way). For now, I just personally needed GLFW, made a config for it, and decided to share.