extract_metadata: Improve detection of mainReadsParams #17702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although its not really important that we detect this case in unoptmized builds it was leading to some strange differences between optimized and unoptimized builds. |
kripken
reviewed
Aug 22, 2022
sbc100
force-pushed
the
main_read_params
branch
from
d8b37c7 to
8009497
Compare
kripken
approved these changes
Aug 22, 2022
sbc100
force-pushed
the
main_read_params
branch
from
8009497 to
69521bc
Compare
In non-optimizing modes llvm can generate extra local.set/local.get instructions which was throwing off this function.
sbc100
force-pushed
the
main_read_params
branch
from
69521bc to
55662a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-optimizing modes llvm can generate extra local.set/local.get
instructions which was throwing off this function.